test_bot_config.py 11 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287
  1. from __future__ import annotations
  2. import json
  3. import pytest
  4. from aiohttp import CookieJar
  5. from aiohttp.test_utils import TestClient, TestServer
  6. def test_multiple_bot_profiles_are_atomic_and_redacted(app_modules, tmp_path):
  7. config = app_modules.load("wbb.admin.bot_config")
  8. path = tmp_path / "bots.json"
  9. first_token = "123456:" + "A" * 30
  10. second_token = "654321:" + "B" * 30
  11. config.update_telegram_config(path, {"api_id": 12345, "api_hash": "a" * 32})
  12. first = config.create_bot_profile(
  13. path,
  14. {
  15. "label": "Primary",
  16. "bot_token": first_token,
  17. "sudo_users_id": "100 200 100",
  18. "message_dump_chat": -100123,
  19. },
  20. )
  21. second = config.create_bot_profile(
  22. path,
  23. {"label": "Secondary", "bot_token": second_token, "enabled": False},
  24. )
  25. status = config.telegram_config_status(path)
  26. assert status["api_ready"] is True
  27. assert len(status["bots"]) == 2
  28. assert status["bots"][0]["sudo_users_id"] == ["100", "200"]
  29. assert status["bots"][0]["role_ids"] == ["full_access"]
  30. assert status["bots"][0]["permissions"]
  31. assert "teacher_directory.manage" in status["bots"][0]["permissions"]
  32. serialized = json.dumps(status)
  33. assert first_token not in serialized
  34. assert second_token not in serialized
  35. assert "a" * 32 not in serialized
  36. assert path.stat().st_mode & 0o777 == 0o600
  37. config.update_bot_profile(path, first["bot_id"], {"label": "Renamed", "bot_token": ""})
  38. stored = config.get_bot_profile_secrets(path, first["bot_id"])
  39. assert stored["bot_token"] == first_token
  40. assert stored["label"] == "Renamed"
  41. config.delete_bot_profile(path, second["bot_id"])
  42. assert len(config.telegram_config_status(path)["bots"]) == 1
  43. def test_custom_roles_are_assignable_and_permissions_are_merged(app_modules, tmp_path):
  44. config = app_modules.load("wbb.admin.bot_config")
  45. path = tmp_path / "bots.json"
  46. config.update_telegram_config(path, {"api_id": 12345, "api_hash": "a" * 32})
  47. role = config.create_bot_role(
  48. path,
  49. {
  50. "name": "积分与抽奖",
  51. "description": "社区运营",
  52. "permissions": ["points.manage", "giveaways.manage"],
  53. },
  54. )
  55. profile = config.create_bot_profile(
  56. path,
  57. {
  58. "label": "Operator",
  59. "bot_token": "123456:" + "A" * 30,
  60. "role_ids": [role["role_id"], "karma_manager"],
  61. },
  62. )
  63. assert profile["role_ids"] == [role["role_id"], "karma_manager"]
  64. assert set(profile["permissions"]) == {
  65. "points.manage",
  66. "giveaways.manage",
  67. "karma.manage",
  68. }
  69. config.update_bot_role(
  70. path,
  71. role["role_id"],
  72. {"permissions": ["automation.manage"]},
  73. )
  74. updated = config.telegram_config_status(path)["bots"][0]
  75. assert set(updated["permissions"]) == {"automation.manage", "karma.manage"}
  76. with pytest.raises(config.BotConfigError) as error:
  77. config.delete_bot_role(path, role["role_id"])
  78. assert error.value.code == "role_in_use"
  79. config.update_bot_profile(path, profile["bot_id"], {"role_ids": []})
  80. config.delete_bot_role(path, role["role_id"])
  81. assert all(
  82. item["role_id"] != role["role_id"]
  83. for item in config.telegram_config_status(path)["roles"]
  84. )
  85. def test_bot_profile_validation(app_modules, tmp_path):
  86. config = app_modules.load("wbb.admin.bot_config")
  87. path = tmp_path / "bots.json"
  88. with pytest.raises(config.BotConfigError) as error:
  89. config.create_bot_profile(path, {"label": "Bad", "bot_token": "not-a-token"})
  90. assert error.value.code == "invalid_bot_token"
  91. with pytest.raises(config.BotConfigError) as error:
  92. config.update_telegram_config(
  93. path,
  94. {"api_id": 12345, "api_hash": "123456:" + "A" * 30},
  95. )
  96. assert error.value.code == "invalid_api_hash"
  97. assert "不能使用机器人令牌" in str(error.value)
  98. def test_role_permissions_gate_telegram_modules(app_modules):
  99. permissions = app_modules.load("wbb.services.bot_permissions")
  100. assert permissions.module_allowed("points", {"points.manage"}) is True
  101. assert permissions.module_allowed("points", {"giveaways.manage"}) is False
  102. assert permissions.module_allowed("admin", {"chat.members"}) is True
  103. assert permissions.module_allowed("admin", {"chat.invites"}) is True
  104. assert permissions.module_allowed("admin", set()) is False
  105. assert permissions.module_allowed("chat_watcher", set()) is True
  106. assert permissions.TELEGRAM_COMMAND_PERMISSIONS["ban"] == "chat.members"
  107. assert permissions.TELEGRAM_COMMAND_PERMISSIONS["pin"] == "chat.announcements"
  108. assert permissions.TELEGRAM_COMMAND_PERMISSIONS["invite"] == "chat.invites"
  109. def test_supervisor_assigns_each_worker_an_isolated_database(app_modules, tmp_path):
  110. supervisor_module = app_modules.load("wbb.admin.supervisor")
  111. supervisor = supervisor_module.BotSupervisor(tmp_path / "bots.json", project_root=tmp_path)
  112. profile = {
  113. "bot_id": "bot.one/secondary",
  114. "bot_token": "123456:" + "A" * 30,
  115. "api_id": 12345,
  116. "api_hash": "a" * 32,
  117. "sudo_users_id": [],
  118. "log_group_id": 0,
  119. "gban_log_group_id": 0,
  120. "message_dump_chat": 0,
  121. "permissions": ["points.manage", "giveaways.manage"],
  122. }
  123. environment = supervisor._worker_environment(profile, 18088)
  124. assert environment["WBB_BOT_PROFILE_ID"] == "bot.one/secondary"
  125. assert environment["WBB_BOT_DATABASE"] == "wbb_bot_bot_one_secondary"
  126. assert environment["WBB_BOT_PERMISSIONS"] == "points.manage,giveaways.manage"
  127. async def test_bot_admin_api_crud_and_token_test_are_redacted(app_modules, monkeypatch):
  128. admin_api = app_modules.load("wbb.admin.api")
  129. application = admin_api.build_admin_application()
  130. await application["admin_api"].initialize()
  131. client = TestClient(TestServer(application), cookie_jar=CookieJar(unsafe=True))
  132. await client.start_server()
  133. token = "123456:" + "C" * 30
  134. try:
  135. login = await client.post(
  136. "/api/admin/v1/auth/login",
  137. json={"username": "admin", "password": "qwe0.123456"},
  138. )
  139. login_data = (await login.json())["data"]
  140. changed = await client.put(
  141. "/api/admin/v1/auth/password",
  142. headers={"X-CSRF-Token": login_data["csrf_token"]},
  143. json={
  144. "current_password": "qwe0.123456",
  145. "new_password": "changed-pass-123",
  146. },
  147. )
  148. csrf = (await changed.json())["data"]["csrf_token"]
  149. headers = {"X-CSRF-Token": csrf}
  150. telegram = await client.put(
  151. "/api/admin/v1/settings/telegram",
  152. headers=headers,
  153. json={"api_id": 12345, "api_hash": "d" * 32, "confirm": True},
  154. )
  155. assert telegram.status == 200
  156. assert (await telegram.json())["data"]["api_hash_configured"] is True
  157. created_role = await client.post(
  158. "/api/admin/v1/roles",
  159. headers=headers,
  160. json={
  161. "name": "积分专员",
  162. "description": "只负责积分",
  163. "permissions": ["points.manage"],
  164. "confirm": True,
  165. },
  166. )
  167. assert created_role.status == 201
  168. role = (await created_role.json())["data"]
  169. created = await client.post(
  170. "/api/admin/v1/bots",
  171. headers=headers,
  172. json={
  173. "label": "Test Bot",
  174. "bot_token": token,
  175. "enabled": False,
  176. "role_ids": [role["role_id"]],
  177. "confirm": True,
  178. },
  179. )
  180. assert created.status == 201
  181. created_payload = await created.json()
  182. profile = created_payload["data"]
  183. assert profile["bot_token_configured"] is True
  184. assert profile["permissions"] == ["points.manage"]
  185. assert token not in json.dumps(created_payload)
  186. async def fake_test_bot_token(_token: str):
  187. assert _token == token
  188. return {"id": "123456", "username": "test_bot", "name": "Test Bot"}
  189. monkeypatch.setattr(admin_api, "test_bot_token", fake_test_bot_token)
  190. tested = await client.post(
  191. f"/api/admin/v1/bots/{profile['bot_id']}/test",
  192. headers=headers,
  193. json={"confirm": True},
  194. )
  195. assert tested.status == 200
  196. assert (await tested.json())["data"]["username"] == "test_bot"
  197. listed = await client.get("/api/admin/v1/bots")
  198. listed_payload = await listed.json()
  199. assert listed_payload["data"]["items"][0]["identity"]["username"] == "test_bot"
  200. assert token not in json.dumps(listed_payload)
  201. deleted = await client.delete(
  202. f"/api/admin/v1/bots/{profile['bot_id']}",
  203. headers=headers,
  204. json={"confirm": True},
  205. )
  206. assert deleted.status == 200
  207. deleted_role = await client.delete(
  208. f"/api/admin/v1/roles/{role['role_id']}",
  209. headers=headers,
  210. json={"confirm": True},
  211. )
  212. assert deleted_role.status == 200
  213. finally:
  214. await client.close()
  215. async def test_bot_role_permission_is_enforced_by_worker_api(app_modules):
  216. admin_api = app_modules.load("wbb.admin.api")
  217. app_modules.wbb.BOT_PERMISSIONS = set()
  218. application = admin_api.build_admin_application()
  219. await application["admin_api"].initialize()
  220. client = TestClient(TestServer(application), cookie_jar=CookieJar(unsafe=True))
  221. await client.start_server()
  222. try:
  223. login = await client.post(
  224. "/api/admin/v1/auth/login",
  225. json={"username": "admin", "password": "qwe0.123456"},
  226. )
  227. login_data = (await login.json())["data"]
  228. changed = await client.put(
  229. "/api/admin/v1/auth/password",
  230. headers={"X-CSRF-Token": login_data["csrf_token"]},
  231. json={
  232. "current_password": "qwe0.123456",
  233. "new_password": "changed-pass-123",
  234. },
  235. )
  236. assert changed.status == 200
  237. denied = await client.get(
  238. "/api/admin/v1/points/accounts?chat_id=-100"
  239. )
  240. assert denied.status == 403
  241. payload = await denied.json()
  242. assert payload["error"]["code"] == "bot_role_permission_denied"
  243. assert payload["error"]["details"]["required_permission"] == "points.manage"
  244. app_modules.wbb.BOT_PERMISSIONS = {"points.manage"}
  245. allowed = await client.get(
  246. "/api/admin/v1/points/accounts?chat_id=-100"
  247. )
  248. assert allowed.status == 200
  249. finally:
  250. await client.close()